Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22893
I don't think BLAS matters here as these are all vector-vector operations
and f2jblas is used directly (i.e. stays in the JVM).
Are all the vectors dense? I suppose I'm still surprised if sqdist is
faster than dot here as it ought to be a little more math. The sparse-dense
case might come out differently, note.
And I suppose I have a hard time believing that the sparse-sparse case is
faster after this change (when the precision bound is met) because now it's
handled in the sparse-sparse if case in this code, which definitely does a dot
plus more work.
(If you did remove this check you could remove some other values that get
computed to check this bound, like precision1)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
