Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21732#discussion_r230726136
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala ---
@@ -393,4 +431,18 @@ class DatasetAggregatorSuite extends QueryTest with
SharedSQLContext {
assert(grouped.schema == df.schema)
checkDataset(grouped.as[OptionBooleanData], OptionBooleanData("bob",
Some(true)))
}
+
+ test("SPARK-24762: Aggregator should be able to use Option of Product
encoder") {
+ val df = Seq(
+ OptionBooleanIntData("bob", Some((true, 1))),
+ OptionBooleanIntData("bob", Some((false, 2))),
+ OptionBooleanIntData("bob", None)).toDF()
+
+ val group = df
+ .groupBy("name")
+ .agg(OptionBooleanIntAggregator("isGood").toColumn.alias("isGood"))
+ assert(df.schema == group.schema)
--- End diff --
let's write down the expected schema
```
val expectedSchema = ...
assert(df.schema == expectedSchema)
assert(grouped.schema == ...)
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
