[GitHub] spark pull request #22943: [SPARK-25098][SQL] Trim the string when cast stri...

[wangyum]

Github user wangyum commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22943#discussion_r230970713
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
 ---
    @@ -359,7 +359,7 @@ case class Cast(child: Expression, dataType: DataType, 
timeZoneId: Option[String
       // TimestampConverter
       private[this] def castToTimestamp(from: DataType): Any => Any = from 
match {
         case StringType =>
    -      buildCast[UTF8String](_, utfs => 
DateTimeUtils.stringToTimestamp(utfs, timeZone).orNull)
    +      buildCast[UTF8String](_, s => 
DateTimeUtils.stringToTimestamp(s.trim(), timeZone).orNull)
    --- End diff --
    
    How about change `stringToDate` to `trimStringToDate` and update 
`trimStringToDate` to:
    
![image](https://user-images.githubusercontent.com/5399861/48036353-ec49a100-e1a2-11e8-80e6-b52b4a007493.png)



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org