Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21306#discussion_r231707076
  
    --- Diff: 
sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/TableChange.java ---
    @@ -0,0 +1,182 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.catalog.v2;
    +
    +import org.apache.spark.sql.types.DataType;
    +
    +/**
    + * TableChange subclasses represent requested changes to a table. These 
are passed to
    + * {@link TableCatalog#alterTable}. For example,
    + * <pre>
    + *   import TableChange._
    + *   val catalog = source.asInstanceOf[TableSupport].catalog()
    + *   catalog.alterTable(ident,
    + *       addColumn("x", IntegerType),
    + *       renameColumn("a", "b"),
    + *       deleteColumn("c")
    + *     )
    + * </pre>
    + */
    +public interface TableChange {
    --- End diff --
    
    @mccheah, our table format supports updating the partitioning of a table, 
so I think it should be supported. But, this is intended to be an initial API 
so I didn't want to block this on agreeing how to repartition a table.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to