Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22951#discussion_r231776568
  
    --- Diff: python/pyspark/sql/readwriter.py ---
    @@ -267,7 +270,8 @@ def json(self, path, schema=None, 
primitivesAsString=None, prefersDecimal=None,
                 mode=mode, 
columnNameOfCorruptRecord=columnNameOfCorruptRecord, dateFormat=dateFormat,
                 timestampFormat=timestampFormat, multiLine=multiLine,
                 allowUnquotedControlChars=allowUnquotedControlChars, 
lineSep=lineSep,
    -            samplingRatio=samplingRatio, 
dropFieldIfAllNull=dropFieldIfAllNull, encoding=encoding)
    +            samplingRatio=samplingRatio, 
dropFieldIfAllNull=dropFieldIfAllNull, encoding=encoding,
    --- End diff --
    
    @MaxGekk, let's also add `dropFieldIfAllNull` and `encoding` in 
`sql/streaming.py` in a separate PR.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to