Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22969#discussion_r231783323
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -787,7 +789,7 @@ case class HashAggregateExec(
| $unsafeRowKeys, ${hashEval.value});
| if ($unsafeRowBuffer == null) {
| // failed to allocate the first page
- | throw new OutOfMemoryError("No enough memory for
aggregation");
+ | throw new $oomeClassName("No enough memory for aggregation");
--- End diff --
Yes, I think so based on my investigation. I grep-ed with
"OutOfMemoryError" and checked the suspicious places.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
