Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22970#discussion_r231833555
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/WideTableBenchmark.scala
---
@@ -42,7 +43,7 @@ object WideTableBenchmark extends SqlBasedBenchmark {
Seq("10", "100", "1024", "2048", "4096", "8192", "65536").foreach {
n =>
benchmark.addCase(s"split threshold $n", numIters = 5) { iter =>
withSQLConf(SQLConf.CODEGEN_METHOD_SPLIT_THRESHOLD.key -> n) {
- df.selectExpr(columns: _*).foreach(identity(_))
+ df.selectExpr(columns: _*).foreach((x => x): Row => Unit)
--- End diff --
shall we use `foreach(_ => ())`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
