Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22989#discussion_r232271235 --- Diff: dev/checkstyle.xml --- @@ -64,6 +64,11 @@ <property name="message" value="No trailing whitespace allowed."/> </module> + <module name="RegexpSingleline"> + <property name="format" value="throw new OutOfMemoryError"/> + <property name="message" value="Throw OutOfMemoryError will kill entire executor, replace it with SparkOutOfMemoryError."/> --- End diff -- Just say that OutOfMemoryError should not generally be thrown by application code. It may not actually be replaceable by SparkOutOfMemoryError
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org