Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23006#discussion_r232486474
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
    @@ -491,7 +491,8 @@ class DataFrameReader private[sql](sparkSession: 
SparkSession) extends Logging {
         val parsedOptions: CSVOptions = new CSVOptions(
           extraOptions.toMap,
           sparkSession.sessionState.conf.csvColumnPruning,
    -      sparkSession.sessionState.conf.sessionLocalTimeZone)
    +      sparkSession.sessionState.conf.sessionLocalTimeZone,
    +      sparkSession.sessionState.conf.columnNameOfCorruptRecord)
    --- End diff --
    
    @MaxGekk, do you mind if I ask separate the current constructor in 
`CSVOptions` to, one requiring  `defaultColumnNameOfCorruptRecord` and one 
`defaultColumnNameOfCorruptRecord` with default value `""`, and then make some 
comments about when they are called?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to