GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/23012

    [SPARK-26014][R] Deprecate R prior to version 3.4 in SparkR

    ## What changes were proposed in this pull request?
    
    This PR proposes to bump up the minimum versions of R from 3.1 to 3.4.
    
    R version. 3.1.x is too old. It's released 4.5 years ago. R 3.4.0 is 
released 1.5 years ago. Considering the timing for Spark 3.0, deprecating lower 
versions, bumping up R to 3.4 might be reasonable option.
    
    It should be good to deprecate and drop < R 3.4 support.
    
    If we think about the practice, nothing particular is required within R 
codes as far as I can tell, except:
    
    1. 
https://github.com/apache/spark/blob/master/R/pkg/src-native/string_hash_code.c
    2. `env` becomes immutable but in some low versions they are mutable ... if 
I remember correctly .. shouldn't be a big deal in SparkR side.
    3. We will need to upgrade Jenkins's R version to 3.4, which mean we're not 
going to test 3.1 R version - this should be okay because we're already not 
testing R 3.2, 3.3 and 3.4. We test 3.5 in Appveyor, and 3.1 in Jenkins.
    
    ## How was this patch tested?
    
    Jenkins tests. 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark SPARK-26014

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/23012.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23012
    
----
commit dc2dbd923a1396ca5a7a950df35da57cc70c2ab8
Author: hyukjinkwon <gurwls223@...>
Date:   2018-11-12T05:39:14Z

    Deprecate R prior to version 3.4 in SparkR

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to