Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22429
@MaxGekk, couple of questions for its implementation from a cursory look.
It's the implementation is complicated here:
1. it tries to use writer and avoid to construct the string. I think it's
unlikely a single plan causes OOO. I think you can just iterate the plan and
write out the trees.
2. This looks introduces `None` concept to indicate no limit which makes
this PR hard to read. I think it's okay to expose that number to `toFile`. I
think this is an internal API, right? People could just set whatever number
they want I guess.
Fix me if I misread. If we get rid of those two points, I think the PR size
will be drastically small.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
