Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23015#discussion_r232661121
--- Diff: project/MimaExcludes.scala ---
@@ -105,7 +105,50 @@ object MimaExcludes {
ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("org.apache.spark.ml.param.shared.HasValidationIndicatorCol.validationIndicatorCol"),
// [SPARK-23042] Use OneHotEncoderModel to encode labels in
MultilayerPerceptronClassifier
-
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.ml.classification.LabelConverter")
+
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.ml.classification.LabelConverter"),
+
+ // [SPARK-21842][MESOS] Support Kerberos ticket renewal and creation
in Mesos
+
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.deploy.SparkHadoopUtil.getDateOfNextUpdate"),
+
+ // [SPARK-23366] Improve hot reading path in ReadAheadInputStream
+
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.io.ReadAheadInputStream.this"),
+
+ // [SPARK-22941][CORE] Do not exit JVM when submit fails with
in-process launcher.
+
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.deploy.SparkSubmit.addJarToClasspath"),
+
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.deploy.SparkSubmit.mergeFileLists"),
+
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.deploy.SparkSubmit.prepareSubmitEnvironment$default$2"),
+
+ // Data Source V2 API changes
--- End diff --
I tried to exclude them from mima check, but unfortunately the
Unstable/Evolving/Stable annotations have a bug: they are not retained in the
class file like `Experimental` annotation, so mima is not aware of them.
I'll fix it in another PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
