Github user xuanyuanking commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22989#discussion_r232984147
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/feature/VectorIndexerSuite.scala ---
    @@ -283,7 +283,9 @@ class VectorIndexerSuite extends MLTest with 
DefaultReadWriteTest with Logging {
             points.zip(rows.map(_(0))).foreach {
               case (orig: SparseVector, indexed: SparseVector) =>
                 assert(orig.indices.length == indexed.indices.length)
    -          case _ => throw new UnknownError("Unit test has a bug in it.") 
// should never happen
    +          case _ =>
    +            // should never happen
    +            throw new IllegalAccessException("Unit test has a bug in it.")
    --- End diff --
    
    Thanks, done in a4f49ce by just `fail` here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to