Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/22880#discussion_r233179076 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala --- @@ -202,8 +204,12 @@ private[parquet] class ParquetRowConverter( override def start(): Unit = { var i = 0 - while (i < currentRow.numFields) { + while (i < fieldConverters.length) { fieldConverters(i).updater.start() + i += 1 + } + i = 0 + while (i < currentRow.numFields) { --- End diff -- Yes, but I think it's clearer this way. If @viirya has an opinion either way I'll take it as a "tie-breaker".
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org