Github user wangyum commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23004#discussion_r233272718
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
 ---
    @@ -237,6 +237,13 @@ case class InMemoryTableScanExec(
           if list.forall(ExtractableLiteral.unapply(_).isDefined) && 
list.nonEmpty =>
           list.map(l => statsFor(a).lowerBound <= l.asInstanceOf[Literal] &&
             l.asInstanceOf[Literal] <= statsFor(a).upperBound).reduce(_ || _)
    +
    +    case StartsWith(a: AttributeReference, ExtractableLiteral(l)) =>
    +      statsFor(a).lowerBound.substr(0, Length(l)) <= l &&
    +        l <= statsFor(a).upperBound.substr(0, Length(l))
    +    case StartsWith(ExtractableLiteral(l), a: AttributeReference) =>
    --- End diff --
    
    Good question, The last one should be removed, `DataSourceStrategy` has the 
same logic:  
https://github.com/apache/spark/blob/3d6b68b030ee85a0f639dd8e9b68aedf5f27b46f/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala#L512-L513


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to