Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20788#discussion_r233678942
--- Diff: python/pyspark/sql/tests/test_dataframe.py ---
@@ -375,6 +375,19 @@ def test_generic_hints(self):
plan = df1.join(df2.hint("broadcast"),
"id")._jdf.queryExecution().executedPlan()
self.assertEqual(1, plan.toString().count("BroadcastHashJoin"))
+ # add tests for SPARK-23647 (test more types for hint)
+ def test_extended_hint_types(self):
+ from pyspark.sql import DataFrame
+
+ df = self.spark.range(10e10).toDF("id")
+ such_a_nice_list = ["itworks1", "itworks2", "itworks3"]
--- End diff --
@DylanGuedes, what do we get if `dict` is given? looks not being tested. If
that produces a weird result, we can disallow it here for now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
