Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r233787377
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -133,30 +126,26 @@ object GenerateOrdering extends
CodeGenerator[Seq[SortOrder], Ordering[InternalR
returnType = "int",
makeSplitFunction = { body =>
s"""
- InternalRow ${ctx.INPUT_ROW} = null; // Holds current row being
evaluated.
- $body
- return 0;
- """
+ |$body
+ |return 0;
+ """.stripMargin
},
foldFunctions = { funCalls =>
funCalls.zipWithIndex.map { case (funCall, i) =>
val comp = ctx.freshName("comp")
s"""
- int $comp = $funCall;
- if ($comp != 0) {
- return $comp;
- }
- """
+ |int $comp = $funCall;
+ |if ($comp != 0) {
+ | return $comp;
+ |}
+ """.stripMargin
}.mkString
})
ctx.currentVars = oldCurrentVars
ctx.INPUT_ROW = oldInputRow
// make sure INPUT_ROW is declared even if splitExpressions
// returns an inlined block
--- End diff --
sorry didn't see this comment when merging. feel free to send a follow-up.
thanks!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
