Github user wangyum commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23030#discussion_r234386679
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
 ---
    @@ -598,13 +597,25 @@ private[yarn] class YarnAllocator(
                 (false, s"Container ${containerId}${onHostStr} was preempted.")
               // Should probably still count memory exceeded exit codes 
towards task failures
               case VMEM_EXCEEDED_EXIT_CODE =>
    -            (true, memLimitExceededLogMessage(
    -              completedContainer.getDiagnostics,
    -              VMEM_EXCEEDED_PATTERN))
    +            val vmemExceededPattern = raw"$MEM_REGEX of $MEM_REGEX virtual 
memory used".r
    +            val diag = 
vmemExceededPattern.findFirstIn(completedContainer.getDiagnostics)
    +              .map(_.concat(".")).getOrElse("")
    +            val additional = if 
(conf.getBoolean(YarnConfiguration.NM_VMEM_CHECK_ENABLED,
    --- End diff --
    
    I see. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to