Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23065#discussion_r234393870
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ProcessingTimeExecutorSuite.scala
 ---
    @@ -48,7 +45,7 @@ class ProcessingTimeExecutorSuite extends SparkFunSuite 
with TimeLimits {
       }
     
       test("trigger timing") {
    -    val triggerTimes = new ConcurrentHashSet[Int]
    +    val triggerTimes = ConcurrentHashMap.newKeySet[Int]()
    --- End diff --
    
    Yes, this is the recommended way to get a concurrent Set in the JDK


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to