Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23084#discussion_r234661975
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -741,7 +742,7 @@ public boolean append(Object kbase, long koff, int
klen, Object vbase, long voff
if (numKeys >= growthThreshold && longArray.size() < MAX_CAPACITY)
{
try {
growAndRehash();
- } catch (OutOfMemoryError oom) {
+ } catch (SparkOutOfMemoryError oom) {
--- End diff --
do you know what was the behavior before? Will we propagate the exception
all the way up and kill the executor?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
