Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23054#discussion_r235238609
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -1594,6 +1594,15 @@ object SQLConf {
             "WHERE, which does not follow SQL standard.")
           .booleanConf
           .createWithDefault(false)
    +
    +  val ALIAS_NON_STRUCT_GROUPING_KEY_AS_VALUE =
    +    buildConf("spark.sql.legacy.dataset.aliasNonStructGroupingKeyAsValue")
    +      .internal()
    +      .doc("When set to true, the key attribute resulted from running 
`Dataset.groupByKey` " +
    +        "for non-struct key type, will be named as `value`, following the 
behavior of Spark " +
    --- End diff --
    
    so it's "named" as value, not "alias" to value. I think it's more precise 
to call this config `spark.sql.legacy.dataset.nameNonStructGroupingKeyAsValue`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to