Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r236112256
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -546,33 +546,29 @@ case class MapConcat(children: Seq[Expression])
extends ComplexTypeMergingExpres
override def nullable: Boolean = children.exists(_.nullable)
+ private lazy val mapBuilder = new ArrayBasedMapBuilder(dataType.keyType,
dataType.valueType)
+
override def eval(input: InternalRow): Any = {
- val maps = children.map(_.eval(input))
+ val maps = children.map(_.eval(input).asInstanceOf[MapData]).toArray
--- End diff --
BTW, if it's not true anymore with scala 2.12, we should update them
together with a bechmark, instead of only updating this single one.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
