Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23127#discussion_r236151394
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
    @@ -199,4 +199,6 @@ case class RDDScanExec(
       override def simpleString: String = {
         s"$nodeName${truncatedString(output, "[", ",", "]")}"
       }
    +
    +  override def inputRDD: RDD[InternalRow] = rdd
    --- End diff --
    
    The test failure is real.  `RDDScanExec.rdd` may not be RDD of unsafe row. 
Maybe we should enforce that, `InputRDDCodegen.inputRDD` is `RDD[UnsafeRow]`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to