Github user squito commented on the issue:
https://github.com/apache/spark/pull/23058
lgtm
I looked more into the lifecycle of the buffers and when they get
`disposed`, and it looks fine to me. (In fact I think there is no need for the
`dispose` in the first place, as hinted at here:
https://github.com/apache/spark/pull/22511#issuecomment-424429691)
I also checked about whether we should buffer the input stream, but
`dataDeserializeStream` already does that.
@wypoon one thing, can you update the testing section of the pr description
to mention the coverage you found in the existing unit tests?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
