Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r236769432
--- Diff:
core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala ---
@@ -84,6 +122,8 @@ case object MappedPoolMemory extends
MBeanExecutorMetricType(
"java.nio:type=BufferPool,name=mapped")
private[spark] object ExecutorMetricType {
+ final val pTreeInfo = new ProcfsBasedSystems
--- End diff --
Normally having an object helps make it clear that there is a singleton;
its easier to share properly and easier to figure out how to get a handle on
it. Given that we'll have a class anyway, I don't think there is a ton of
value in having there be a companion object.
I do still think the instance you create here should go somewhere else.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
