Github user rdblue commented on the issue: https://github.com/apache/spark/pull/23086 @cloud-fan, sorry to spread review comments over two days, but I've finished the first pass. Overall, it looks great. I think we can simplify a couple of areas, like all of the args passed to the ScanExec node and its equals method. I'd also like to add `name` to table to return an identifying string (even if that is a set of options or paths in some cases). Thanks for working on this!
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org