Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23151#discussion_r236912182
  
    --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
    @@ -105,5 +105,16 @@ abstract class SparkFunSuite
           logInfo(s"\n\n===== FINISHED $shortSuiteName: '$testName' =====\n")
         }
       }
    -
    +  /**
    +   * Creates a temporary directory, which is then passed to `f` and will 
be deleted after `f`
    +   * returns.
    +   *
    +   * @todo Probably this method should be moved to a more general place
    +   */
    +  protected def withCreateTempDir(f: File => Unit): Unit = {
    --- End diff --
    
    Is there any reason not to use `withTempDir` as a function name like other 
modules?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to