Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23161#discussion_r236972877
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -2732,14 +2732,24 @@ setMethod("union",
                 dataFrame(unioned)
               })
     
    -#' Return a new SparkDataFrame containing the union of rows
    -#'
    -#' This is an alias for `union`.
    +#' Return a new SparkDataFrame containing the union of rows.
    +#' This is an alias for \code{union}.
     #'
    -#' @rdname union
    -#' @name unionAll
    +#' @param x a SparkDataFrame.
    +#' @param y a SparkDataFrame.
    +#' @return A SparkDataFrame containing the result of the unionAll 
operation.
    +#' @family SparkDataFrame functions
     #' @aliases unionAll,SparkDataFrame,SparkDataFrame-method
    -#' @note unionAll since 1.4.0
    +#' @rdname unionAll
    +#' @name unionAll
    --- End diff --
    
    I'd add a `@seealso` to union


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to