Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r236973308
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapData.scala
---
@@ -19,6 +19,12 @@ package org.apache.spark.sql.catalyst.util
import java.util.{Map => JavaMap}
+/**
+ * A simple `MapData` implementation which is backed by 2 arrays.
+ *
+ * Note that, user is responsible to guarantee that the key array does not
have duplicated
+ * elements, otherwise the behavior is undefined.
--- End diff --
nit: we might need to add the same note to the 3rd and 4th
`ArrayBasedMapData.apply()` method.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
