Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23176#discussion_r237383211
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/PredicateSuite.scala
 ---
    @@ -293,6 +293,54 @@ class PredicateSuite extends SparkFunSuite with 
ExpressionEvalHelper {
         }
       }
     
    +  test("INSET: binary") {
    +    val hS = HashSet[Any]() + Array(1.toByte, 2.toByte) + Array(3.toByte)
    +    val nS = HashSet[Any]() + Array(1.toByte, 2.toByte) + Array(3.toByte) 
+ null
    +    val onetwo = Literal(Array(1.toByte, 2.toByte))
    +    val three = Literal(Array(3.toByte))
    +    val threefour = Literal(Array(3.toByte, 4.toByte))
    +    val nl = Literal(null, onetwo.dataType)
    +    checkEvaluation(InSet(onetwo, hS), true)
    +    checkEvaluation(InSet(three, hS), true)
    +    checkEvaluation(InSet(three, nS), true)
    --- End diff --
    
    this line is duplicated


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to