Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22957#discussion_r237532156
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
    @@ -2542,10 +2542,10 @@ object EliminateUnions extends Rule[LogicalPlan] {
      * rule can't work for those parameters.
      */
     object CleanupAliases extends Rule[LogicalPlan] {
    -  private def trimAliases(e: Expression): Expression = {
    +  private[catalyst] def trimAliases(e: Expression): Expression = {
         e.transformDown {
    -      case Alias(child, _) => child
    -      case MultiAlias(child, _) => child
    +      case Alias(child, _) => trimAliases(child)
    --- End diff --
    
    it's `transformDown`, why doesn't it work?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to