Github user koertkuipers commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23173#discussion_r237687091
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
 ---
    @@ -1987,6 +1987,18 @@ class CSVSuite extends QueryTest with 
SharedSQLContext with SQLTestUtils with Te
         assert(errMsg2.contains("'lineSep' can contain only 1 character"))
       }
     
    +  test("SPARK-26208: write and read empty data to csv file with header") {
    +    withTempPath { path =>
    +      val df1 = Seq.empty[(String, String)].toDF("x", "y")
    --- End diff --
    
    i can do that, but i think when i write it out and read it back in it will 
come back in as 1 partition (one part file with header) because of SPARK-23271. 
is that worth checking for?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to