Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23152#discussion_r237721273
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
---
@@ -879,13 +879,13 @@ case class ColumnStatsMap(originalMap:
AttributeMap[ColumnStat]) {
}
def hasCountStats(a: Attribute): Boolean =
- get(a).map(_.hasCountStats).getOrElse(false)
+ get(a).exists(_.hasCountStats)
def hasDistinctCount(a: Attribute): Boolean =
- get(a).map(_.distinctCount.isDefined).getOrElse(false)
+ get(a).exists(_.distinctCount.isDefined)
def hasMinMaxStats(a: Attribute): Boolean =
- get(a).map(_.hasCountStats).getOrElse(false)
+ get(a).exists(_.hasMinMaxStats)
--- End diff --
@liancheng Thanks. @adrian-wang Can you also add a test based on that?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
