Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23166#discussion_r237886286
  
    --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala 
---
    @@ -708,16 +709,36 @@ private[spark] class PythonBroadcast(@transient var 
path: String) extends Serial
           override def handleConnection(sock: Socket): Unit = {
             val env = SparkEnv.get
             val in = sock.getInputStream()
    -        val dir = new File(Utils.getLocalDir(env.conf))
    -        val file = File.createTempFile("broadcast", "", dir)
    -        path = file.getAbsolutePath
    -        val out = env.serializerManager.wrapForEncryption(new 
FileOutputStream(path))
    +        val abspath = new File(path).getAbsolutePath
    +        val out = env.serializerManager.wrapForEncryption(new 
FileOutputStream(abspath))
    --- End diff --
    
    yes +1.  Sorry didn't mean to get things stuck on this, just wanted to make 
sure I was actually following what was happening correctly.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to