Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23183#discussion_r238014562
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/QueryPlanningTracker.scala
 ---
    @@ -51,6 +58,18 @@ object QueryPlanningTracker {
         }
       }
     
    +  /**
    +   * Summary of a phase, with start time and end time so we can construct 
a timeline.
    +   */
    +  class PhaseSummary(val startTimeMs: Long, val endTimeMs: Long) {
    +
    +    def durationMs: Long = endTimeMs - startTimeMs
    +
    +    override def toString: String = {
    +      s"PhaseSummary($startTimeMs, $endTimeMs)"
    --- End diff --
    
    Also include the duration in toString?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to