Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22957#discussion_r238027941
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
    @@ -780,6 +780,23 @@ class PlannerSuite extends SharedSQLContext {
             classOf[PartitioningCollection])
         }
       }
    +
    +  test("SPARK-25951: avoid redundant shuffle on rename") {
    --- End diff --
    
    I think the test case coverage is not enough for such massive changes. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to