Github user MaxGekk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23150#discussion_r238075664
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
 ---
    @@ -622,10 +623,11 @@ class CSVSuite extends QueryTest with 
SharedSQLContext with SQLTestUtils with Te
         val options = Map(
           "header" -> "true",
           "inferSchema" -> "false",
    -      "dateFormat" -> "dd/MM/yyyy hh:mm")
    +      "dateFormat" -> "dd/MM/yyyy HH:mm")
    --- End diff --
    
    According to iso 8601:
    ```
    h       clock-hour-of-am-pm (1-12)  number            12
    H       hour-of-day (0-23)          number            0
    ```
    but real data is not in the allowed range:
    ```
    date
    26/08/2015 18:00
    27/10/2014 18:30
    28/01/2016 20:00
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to