Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/23199#discussion_r238109668
--- Diff: sql/core/src/test/resources/sql-tests/inputs/literals.sql ---
@@ -53,6 +53,10 @@ select .e3;
-- very large decimals (overflowing double).
select 1E309, -1E309;
+-- float
+select 0F, 1F, 1.2F, -1F, -1.2F, 3.4028235E30F;
+select 3.4028235E39F;
--- End diff --
Could you move the test cases to the end of the file?
Also clearly specify the positive and negative test cases in the comments?
More test cases are needed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
