Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r238328405
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -148,12 +156,25 @@ class SQLQueryTestSuite extends QueryTest with
SharedSQLContext {
})
// When we are regenerating the golden files we don't need to run
all the configs as they
// all need to return the same result
- if (regenerateGoldenFiles && configs.nonEmpty) {
- configs.take(1)
+ if (regenerateGoldenFiles) {
+ if (configs.nonEmpty) {
+ configs.take(1)
+ } else {
+ Array.empty[Array[(String, String)]]
--- End diff --
nit: since configs don't matter when generating result, I think we can just
return empty configs here. We can clean it up in a followup PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
