Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21465#discussion_r238809091
--- Diff: python/pyspark/ml/regression.py ---
@@ -650,19 +650,20 @@ def getFeatureSubsetStrategy(self):
return self.getOrDefault(self.featureSubsetStrategy)
-class TreeRegressorParams(Params):
+class HasVarianceImpurity(Params):
--- End diff --
This shouldn't be changed, impurity is different for regression and
classification, so the param needs to be defined in `TreeRegressorParams` and
`TreeClassifierParams`, as it was already
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
