Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23108#discussion_r238943983
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala 
---
    @@ -2370,4 +2370,51 @@ class HiveDDLSuite
           ))
         }
       }
    +
    +  test("SPARK-25993 Add test cases for resolution of Parquet table 
location") {
    --- End diff --
    
    Also, for the full test coverage, can we have the following combination 
like ORC, too?
    ```
    Seq(true, false).foreach { convertMetastore =>
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to