Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
Sorry, my bad; it was longer than the current master by ~2 times. That's
because the current master has already run two config set patterns
(`wholeStage=true,factoryMode=CODEGEN_ONLY` and
`wholeStage=true,factoryMode=NO_CODEGEN`) in `SQLQueryTestSuite`. The second
test run (`wholeStage=true,factoryMode=NO_CODEGEN`) was introduced in my
previous pr (#22512).
IMHO two config set patterns below could cover most code paths in Spark?
- wholeStage=true, factoryMode=CODEGEN_ONLY
- wholeStage=false, factoryMode=NO_CODEGEN
In this case, there is little change in the test time;
```
// the current master
=== Codegen/Interpreter Time Metrics ===
Total time: 358.584989321 seconds
Configs
Run Time
spark.sql.codegen.wholeStage=true,spark.sql.codegen.factoryMode=NO_CODEGEN
165961038511
spark.sql.codegen.wholeStage=true,spark.sql.codegen.factoryMode=CODEGEN_ONLY
192623950810
// with this pr
=== Codegen/Interpreter Time Metrics ===
Total time: 345.468455247 seconds
Configs
Run Time
spark.sql.codegen.wholeStage=true,spark.sql.codegen.factoryMode=CODEGEN_ONLY
196572976377
spark.sql.codegen.wholeStage=false,spark.sql.codegen.factoryMode=NO_CODEGEN
148895478870
```
WDYT?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
