Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23207#discussion_r239059162
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala 
---
    @@ -163,6 +171,8 @@ object SQLMetrics {
             Utils.bytesToString
           } else if (metricsType == TIMING_METRIC) {
             Utils.msDurationToString
    +      } else if (metricsType == NS_TIMING_METRIC) {
    +        duration => Utils.msDurationToString(duration / 1000 / 1000)
    --- End diff --
    
    will this string lose the nanosecond precision?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to