Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/23236
Seems ok to me, but there are a few silly things with this test that might
help also
* why is the `stepSize` so low at 0.01? I think it would be fine at 0.1,
but even conservatively at 0.03 would still help converge a little faster
* why is it comparing the current error with the second error value
(errors[1] - errors[-1])? Maybe because errors[1] is bigger, but should just be
`errors[0]` and make the values more sensible, like maybe check that error is >
0.2
* having 2 `if` statements to check basically the same condition is a bit
redundant, just `assert(len(errors) < len(predict_batches)` before the last
return
* nit: `true_predicted = []` on line 350 isn't used
If you don't feel comfortable changing any of these, just increasing the
timeout is probably fine
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
