Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22305#discussion_r239307779
  
    --- Diff: python/pyspark/sql/tests/test_pandas_udf_window.py ---
    @@ -87,8 +96,34 @@ def ordered_window(self):
         def unpartitioned_window(self):
             return Window.partitionBy()
     
    +    @property
    +    def sliding_row_window(self):
    +        return Window.partitionBy('id').orderBy('v').rowsBetween(-2, 1)
    +
    +    @property
    +    def sliding_range_window(self):
    +        return Window.partitionBy('id').orderBy('v').rangeBetween(-2, 4)
    +
    +    @property
    +    def growing_row_window(self):
    +        return 
Window.partitionBy('id').orderBy('v').rowsBetween(Window.unboundedPreceding, 3)
    +
    +    @property
    +    def growing_range_window(self):
    +        return Window.partitionBy('id').orderBy('v') \
    +            .rangeBetween(Window.unboundedPreceding, 4)
    +
    +    @property
    +    def shrinking_row_window(self):
    +        return Window.partitionBy('id').orderBy('v').rowsBetween(-2, 
Window.unboundedFollowing)
    +
    +    @property
    +    def shrinking_range_window(self):
    +        return Window.partitionBy('id').orderBy('v') \
    +            .rangeBetween(-3, Window.unboundedFollowing)
    +
         def test_simple(self):
    -        from pyspark.sql.functions import mean
    +        from pyspark.sql.functions import pandas_udf, PandasUDFType, 
percent_rank, mean, max
    --- End diff --
    
    ditto.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to