Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23072#discussion_r239701916
  
    --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
    @@ -968,6 +970,17 @@ predicted <- predict(model, df)
     head(predicted)
     ```
     
    +#### Power Iteration Clustering
    +
    +Power Iteration Clustering (PIC) is a scalable graph clustering algorithm. 
`spark.assignClusters` method runs the PIC algorithm and returns a cluster 
assignment for each input vertex.
    +
    +```{r}
    +df <- createDataFrame(list(list(0L, 1L, 1.0), list(0L, 2L, 1.0),
    +                      list(1L, 2L, 1.0), list(3L, 4L, 1.0),
    --- End diff --
    
    BTW, when I added that into https://spark.apache.org/contributing.html, we 
also agreed upon following committer's judgement based upon the guide because 
the guide mentions:
    
    > The coding conventions described above should be followed, unless there 
is good reason to do otherwise. Exceptions include legacy code and modifying 
third-party code.
    
    since we do have legacy reason, and there is a good reason - consistency 
and committer's judgement.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to