Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23261#discussion_r239998861
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -163,7 +163,7 @@ abstract class MLWriter extends BaseReadWrite with
Logging {
*/
@Since("1.6.0")
@throws[IOException]("If the input path already exists but overwrite is
not enabled.")
- def save(path: String): Unit = {
+ def save(path: String): Unit = MLEvents.withSaveInstanceEvent(this,
path) {
new FileSystemOverwrite().handleOverwrite(path, shouldOverwrite, sc)
saveImpl(path)
--- End diff --
and `saveImpl` is already existent as well.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
