[GitHub] spark pull request #23263: [SPARK-23674][ML] Adds Spark ML Events

[viirya]

Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23263#discussion_r240003563
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
    @@ -132,7 +132,8 @@ class Pipeline @Since("1.4.0") (
        * @return fitted pipeline
        */
       @Since("2.0.0")
    -  override def fit(dataset: Dataset[_]): PipelineModel = {
    +  override def fit(dataset: Dataset[_]): PipelineModel = super.fit(dataset)
    --- End diff --
    
    Is there any `fit` method which doesn't do `super.fit()`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org