Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23253#discussion_r240026237
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/TestJsonData.scala
 ---
    @@ -229,6 +229,11 @@ private[json] trait TestJsonData {
           """{"date": "27/10/2014 18:30"}""" ::
           """{"date": "28/01/2016 20:00"}""" :: Nil))(Encoders.STRING)
     
    +  def badRecords: Dataset[String] =
    --- End diff --
    
    if it's only used in one test, let's move it to that test


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to