Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23262#discussion_r240026388
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
    @@ -33,7 +33,7 @@ object RDDConversions {
         data.mapPartitions { iterator =>
           val numColumns = outputTypes.length
           val mutableRow = new GenericInternalRow(numColumns)
    -      val converters = 
outputTypes.map(CatalystTypeConverters.createToCatalystConverter)
    +      val converters = 
outputTypes.map(CatalystTypeConverters.createToCatalystConverter).toArray
    --- End diff --
    
    shall we use `ExpressionEncoder` here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to